Skip to content

Add divan_compat msrv check in CI #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

Add divan_compat msrv check in CI #74

merged 2 commits into from
Feb 12, 2025

Conversation

@GuillaumeLagrange
Copy link
Contributor

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #74 will degrade performances by 12.14%

Comparing cod-541-add-msrv-check-in-ci (38f7270) with main (a0b46d4)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 148 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ recursive[0] 211.1 ns 240.3 ns -12.14%
❌ recursive[5] 291.1 ns 320.3 ns -9.11%
⚡ instant 363.6 ns 334.4 ns +8.72%
⚡ system_time 363.6 ns 334.4 ns +8.72%

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #74 will degrade performances by 9.93%

Comparing cod-541-add-msrv-check-in-ci (38f7270) with main (a0b46d4)

Summary

⚡ 3 improvements
❌ 4 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ recursive_memoized[BTreeMap<u64, u64>, 20] 3.5 µs 1.8 µs +97.94%
⚡ graph_coloring[4] 3.9 µs 3.5 µs +11.01%
❌ graph_coloring[5] 4.1 µs 4.3 µs -3.08%
❌ graph_coloring[6] 4.6 µs 4.9 µs -6.82%
❌ hamiltonian_cycle[6] 5.7 µs 5.9 µs -3.44%
❌ permutations[6] 66 µs 73.2 µs -9.93%
⚡ system_time 6.6 µs 3.5 µs +90.38%

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-541-add-msrv-check-in-ci branch from d2a810f to 38f7270 Compare February 12, 2025 15:11
@GuillaumeLagrange GuillaumeLagrange merged commit 38f7270 into main Feb 12, 2025
5 of 6 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-541-add-msrv-check-in-ci branch February 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeLagrange @art049